Help:BNH Project Enhancement Ideas

From Bank Note History
Jump to navigation Jump to search

This page is meant to consolidate Enhancement Ideas for the Bank Note History Project for future programming/wiki consideration.


BankNoteHistory.spmc.org Wiki ideas

B&B Database/Search Webapp ideas

Pending Enhancement Ideas:

  • **** MD: 6/18/21 * Banks & Bankers Database Priority - Get Basic Banker Bio info into B&B Database
  • The goal here is to get SPMC users to research/submit a Banker Bio Link for bankers (Findagrave.com, Wikipedia.com (if famous enough) or other Bio Link).
  • With the changes outlined below, All SPMC users can easily submit BioLinks, and then Admin users can use the Bank Officer Search page to see which bankers (for their State) have Biolinks submitted that need Bio Research/Review (and then they will edit banker to set the Basic Banker Bio Info).
  • 1. In B&B Database, a Banker Bio Link can be submitted by any SPMC user on the Banker Bio Info page (if BioLink2 OR 3 are currently Blank).
    • BBData Webapp tasks:
a. On the Banker Info page, Only show 'Submit Banker BioLink' if BioLink2 or BioLink3 is Blank.
b. Show a popup with just an edit field for a BioLink (250 chars max) and Save/Cancel
c. If Findagrave.com link, set Bankers.BankerBioLink3=NewLink Else set Bankers.BankerBioLink2=NewLink (Note: If only one BioLink field (2 or 3) is blank, put the uploaded link in that field, even if not technically correct. (Admin user will clean it up as needed. Key thing is getting the BioLink easily uploaded to the Banker record).
d. Set (existing field) Bankers.ResearchNeededFlag = 'Y' (default value is 'N')
e. Add record to BBBioLinkSubmitLog (see table create sql below)
(Set fields: LoginName, UserID, UserFullName, UserEmailAddress, BankerID, BioLink)
(Note: Using this submit log, we can track and honor users that are submitting the most BioLinks).
  • 2. On the 'Bank Officer Search' page:
a. (Only) if BBData login User opt (Users.AllowModifyBankerBio) = 'Y', then show a 'Only Show if Bio Research Needed?' checkbox query option (under county(s) edit box?).
b. If checked, then results query SQL should add an and Bankers.ResearchNeededFlag = 'Y' clause to the Where statement.
  • 3. On the View Banker Info page (and Edit Banker Info page):
a. View: Show 'Bio Research Needed?' checkbox (between Biolinks and SourceInfo lines).
b. Edit: Show the same checkbox and allow to edit (Y/N value).
c. Remember to hide the current BioLink link at top of page per previous discussion.


  • Here is the create table SQL for the new log table (I have already created this table on the host):
  • CREATE TABLE [dbo].[BBLinkSubmitLog](
[AutoRecordID] [int] IDENTITY(1,1) NOT NULL,
[LogTimeStamp] [datetime] NULL Default GetDate(),
[LoginName] [varchar](16),
[UserID] [int] NULL Default 0,
[UserFullName] [varchar](60) NULL,
[UserEmailAddress] [varchar](60) NULL,
[BBLinkType] [varchar](12) NULL, --BioLink/BankLink (+maybe BankNoteSig)
[BBID] [integer] NULL, --BankerID/BankID
[BBLink] varchar(250),
[Tag] [char](1) NULL,
PRIMARY KEY (AutoRecordID)
);
GO
===================================================

Possible Future Enhancement Ideas:

  • (wait) **** MD: 3/28/19 Allow to Edit 'Bank History Link' (inline?) on the 'Bank Info Page' (if Users.AllowModifyBankInfo=Y) (The data field is Banks.BankHistoryLink varchar(250)).
  • (wait) * MD: 10/22/2019 Allow to Edit the 3 'Bank History Highlight' fields (60 char edit boxes) on the same screen as Editing the Bank History Link above. (The 3 data fields are Banks.BankHistoryHightlight1,2,3 varchar(60)).
(Note: These should be the Only 4 Bank data fields that would need to be edited in the search webapp)
-------------------------------
  • MD: 9/4/2020: (???) Maybe have a link to show 'Research Notes/Text' on the Banker Info page, displaying text in BankerBio MEMO field (Only show link if memo field is Not Empty).
(I am currently putting raw banker bio research text (ie obits & bios) in this memo field, which IS included in the 'build banker bio page in the wiki' text, but it is not visible from the search webapp).
-------------------------------
  • MD: 5/5/2020: Bank Officer Pairs - Make the BankOfficer name a link to the Banker Info page (Priority 2). (md-Wait on this one).
The CashierBankerID and PresidentBankerID values are already there in the results table of the function that you call, so it would just be a matter of turning the banker names into links (IFF Cashier/PresidentBankerID > 0).
The Banker Info page would then need 3? return opts of Home|OfficerSearch|BankInfo (IFF called from Bank Info page)
OR Home|BankInfo if called from BankInfo, and Home|OfficerSearch if called from OfficerSearch (?)
  • ==============================================================
  • DONE * MD/MDJ: 4/11/2021: 1. Display the 2 new Banker Bio link fields on the 'Banker Info page'. (The 2 new data fields are Bankers.BankerBioLink2 & BankerBioLink3)
View Banker Info page (partial)
  • On the above 'View Banker Info' screen:
    • Change section header to 'Comments, Links & Sources'
    • Add a new line below Comment4: labeled 'Bio Links:'
    • On that new line show the 3 link labels I had typed into the Comment3 & 4 lines to show the label display options.
    • The 'BNHWiki' label links to bankers.BankerBioLink field (if that field is Null/blank, still display the Bio/Wiki label, but have it grayed out/disabled (?) (To show that link is not currently available).
    • The 'Other Bio' label links to bankers.BankerBioLink2 field (if that field is Null/blank, still display the label, but have it grayed out/disabled (?) (To show that link is not currently available).
NOTE: If the BankerBioLink2 field contains the string 'wikipedia.org' then set this label to 'Wikipedia' instead of 'OtherBio'.
    • The 'FindAGrave' label links to bankers.BankerBioLink3 field (if that field is Null/blank, still display the label, but have it grayed out/disabled (?) (To show that link is not currently available).
NOTE: If the BankerBioLink3 field does NOT contain the string 'findagrave.com' then set this label to 'OtherBio' instead of 'FindAGrave'.
    • (Maybe always have the asterisks greyed out to de-emphasize them? or maybe use the 'dot' (not 'period') separator? (I don't know how to echo that char))
    • The above seemed like the easiest/best way to do this. If you have a better idea, let me know.


  • As far as the 'Bio/Wiki' link at the top of the Banker Info page (and in Banker Search results list), I want to handle that a little differently:
    • Label it 'Bio Link' instead of 'Bio/Wiki'.
    • Instead of always using the bankers.BankerBioLink field, use the following SQL to return the first non-null BioLink value:
Select IsNull(IsNull(BankerBioLink,BankerBioLink2),BankerBioLink3) as BioLink
    • NOTE: Also do this for the 'Bio/Wiki' link showing in the Banker Search results list. (Rename the label 'Bio Link', and use that SQL to fetch the link value).
  • DONE * MD/MDJ: 4/11/2021: 2. Allow to edit the 2 new Banker Bio link fields on the 'Banker Info edit page'.
Edit Banker Info page (partial)
  • On the above 'Edit Banker Info' screen:
    • Change section header to 'Comments, Links & Sources'
    • Add a new line below 'Banker Bio/Wiki Link:' labeled 'Other Bio Link:', with the same size edit box (this is bankers.BankerBioField2)
    • Add another new line below 'Other Bio Link:' labeled 'FindAGrave.com Link:', with the same size edit box (this is bankers.BankerBioField3)
    • The above seemed like the easiest/best way to do this. If you have a better idea, let me know.
  • ===========================================
  • DONE * MD/MDJ: 9/3/2020: Type Uncertain idea for 'Bank Note Types Issued' section on the Bank Info page (Priority 1):
I had an idea for a change to the Banks & Bankers Database search web app (on the Bank Info page), to potentially get some better visibility on the 'Type Uncertain' issue, that would hopefully result in more 'fixes' being found/reported to us. (This will also display the other 'Sheet Comments' listed in the BBNBSheetsIssued data table, which will also be good information to see there).


Here is a mockup of what that 'Bank Note Types Issued' section on the Bank Info page for Charter 2395 would look like with the 'Sheet Comments' column also displayed with 'Type uncertain' info.
'Bank Note Types Issued' section for Charter 2395 with the 'Sheet Comments' column also displayed.


Here is the SQL to fetch the data to be displayed:
Select ViewSheetSeries as [Series/Type], ViewSheetDenoms as [Sheet/Denoms],
ViewSheetSerials as [Serial#s], ViewSheetComments as [Sheet Comments]
From BBNBSheetsIssued Where NBCharter = 2395
Order By SortID


and use this SQL to optionally display the 'help us out' message:
If Exists (Select NBCharter From BBNBTypeUncertainMaster
Where NBCharter = 2395 and FixedFlag ='N') = True
then show this msg:
If you find a note in a 'Type uncertain' serial# range, please send
Front AND Back scans of the bank note to banknotehistory@gmail.com,
so we can assign that serial# range to the proper Type. Thanks!


MD Comments:
One thing that might get a little messy about this is the display on a phone with longer Sheet Comments. The current longest Sheet Comment is 45 characters long.
But I guess if it just wraps on a phone, then it's not a big deal, just a messy display, so don't worry about it.
I don't think it's worth hassling trying to show the sheet comments as a 2nd line, especially since that could get confusing, and not associate the 'Type Uncertain' comment specifically with that serial# line, which is important. But if you have any ideas on this let me know.
  • ==============================================================
  • DONE **** MD: (~3/6/20) Enhancements to 'National Bank search by Town or County' (Priority 1):
Add 'County' search box to allow searching by Town OR County(?) (3/5/20-I just added this idea...we can discuss before implementing).
Add 'Exact' and 'Note Issuing Banks Only' checkbox search options (both options default to Checked/Yes)
(Shorten up Town edit box and add 'Exact' checkbox after the Town edit box, and put 'Note Issuing Banks Only' checkbox below that)
(Change button caption to 'List Banks for search Town or County')
(If 'Exact' option is NOT checked, then do a Like search, and add '%' char before AND after Town search text, UNLESS search text includes % or _)
(If 'Note Issuing Banks Only' option is checked, then add 'and Banks.IssuedBanknotesFlag = 'Y' to search where clause)
Here is new sample SQL: (Note the other change in Where clause in italics, that we should have had in the old SQL).
*** This is old. See new SQL in 3/8/20 email.
Select BankState, BankCity, NBCharter, BankTitles, BankOpenYear, BankCloseYear
From Banks
Where BankType = 'NB' and IssuedBanknotesFlag = 'Y'
and NBCharter in (Select Distinct NBCharter From BBVanBelkumMaster Where SearchCity Like '%lexington%')
Order By BankState, BankCity, NBCharter
NOTE: This would mean adding a 'Town' (and County) column (like on the Bank Officer Search page) to the search results list (between State & NBCharter) (wider/messy on phones? s/b ok?)
(Why don't you support the '/' line break character in Town name column like you did in the Bank Title column to keep that column narrower for multi-town banks. Plus if '/' break in Town name, there will also be a corresponding '/' break in Bank Title, so that should match up nicely.
'Exact' option would handle these town name situations (which cause confusion & missing banks from the bank list now).
Pittsburgh & Pittsburg (different town spellings for different banks in the same town)
Eugene City/Eugene (town name changed)
Plum Creek/Lexington (bank moved to different town)
Also would allow searching for collection ideas based on town name (ie 'Peter' towns' - Petersburg, Peterson, Saint Peter, etc)


  • DONE **** MD: (12/06/19) Priority 1a: (Simple Label changes for terminology change from 'City' to more generic 'Town')
On the Bank Officer Search page, change the 'City' to 'Town' in 2 places:
the City(s) search box, and the City/County column header.


  • DONE **** MD: (12/07/19) Priority 1b: (Priority 1b,1c & 1d are all changes on the Bank Info page)
On the Bank Info page, change the section header label
From 'Bank History Timeline (VanBelkum/Huntoon)'
To 'Bank History Summary (VanBelkum/Huntoon/Pollock)'.
On the Bank Info page, move the 'Bank History Link' section down to AFTER the Bank History Summary, instead of before it.


  • DONE **** MD: (12/06/19) Priority 1c:
Show a new section on the Bank Info page, listing the VanBelkum 'Bank Note Types Issued' information.
(This section should go right above the 'Bank Balance Summaries' section).
Bank Note Types Issued (VanBelkum) (This is the Section Title, with (VanBelkum) in grey like other section titles)
Series/Type Sheet/Denoms Serial#s
1882 Brown Back 3x10-20 1-2200
1902 Red Seal 4x5 1-1200
1902 Date Back 3x10-20 1-1200
1902 Plain Back 3x10-20 1201-3500
1929 Type 2 6x100 1-200
(The data table will be 3 (25 char max) columns with a variable number of rows)
(SQL is: Select ViewSheetSeries, ViewSheetDenoms, ViewSheetSerials From BBNBSheetsIssued Where NBCharter = 1234 Order By SortID)
(Note: If the query comes back empty, that means this Natl Bank did not issue bank notes, so skip this section entirely).


  • DONE **** MD: 12/07/19 Priority 1d:
There will also be another new section on the Bank Information page titled 'Bank Officers (Pollock)' (below the 'Official Bank Titles' section) with three Bank Officer listings available here for that National Bank.
I am currently thinking it would be best to have the 1st list (Cashier-President pairings) always list on the Bank Info page, with the other 2 lists below that as links that would open up in a new browser tab, so the user can easily go back to the Bank Information page and/or keep these 2 lists open for reference if needed. (MDJ, we can discuss the best/easiest way to handle this).
Here are the 3 Officer listings:
1. A list of the different Cashier-President pairings with years served (based on the annual OCC Reports).
This list is very helpful for identifying Bankers that have signed a bank note, since this would be the normal pairing of signing officers. It also helps narrow down the year that the note was actually issued by the bank.
2. A list of all of the Presidents for that bank with years served (and maybe include the Bank Officer Summary for each officer here?)
3. A list of all of the Cashiers for that bank with years served (and maybe include the Bank Officer Summary for each officer here?)
All 3 of these listings are generated by calling sql server functions to return the table of records.
1. SQL: Select Years, CashierName, PresidentName From dbo.BBListNBOfficerPairs(NBCharter,'L') [ShortLongNameOpt=S/L, use 'L']
The listing would be a 3 column table looking like:
Years Cashier President
1889-1892 Henry E. Briggs Charles Mylius
1893-1894 W. C. Briggs C. J. Cawley
(Note: Fields CashierBankerID and PresidentBankerID are also available with that query, in case we decide to support the officer names as links to their Banker Info page, but don't do anything with that now).
2. SQL: Select Years, PresidentName From dbo.BBListNBPresidents(NBCharter)
The listing would be a 2 column table looking like: (and maybe include the Bank Officer Summary for each officer here?)
Years President
1889-1892 Charles Mylius
1893-1894 Charles James Cawley
(Note: The PresidentBankerID field is also available with that query, in case we decide to support the officer name as a link to their Banker Info page, but don't do anything with that now).
3. SQL: Select Years, CashierName From dbo.BBListNBCashiers(NBCharter)
The listing would be a 2 column table looking like: (and maybe include the Bank Officer Summary for each officer here?)
Years Cashier
1889-1892 Henry Edwin Briggs
1893-1897 William Currer Briggs
(Note: The CashierBankerID field is also available with that query, in case we decide to support the officer name as a link to their Banker Info page, but don't do anything with that now).


Enhancement Priorities:
  • DONE * The 4 things listed above to show on the Bank Info page, are the 1st priority enhancements.
  • DONE * The 2nd priority would be the new 'quick & easy Bank Search page' as outlined in my 12/6/19 'BBData webapp enhancements' email, that would become the new home page for the web app. So there would be related issues (such as changing the 'auto-login from SPMC website' to start at the new home page, etc).
  • DONE * It would be great to have the Priority 1 & 2 items done before my talk in early January, so I could make a splash there showing off the new stuff, especially the 'quick & easy Bank Search', which I think would go over very well (especially with the 2 new sections of data on the bank info page!).
  • =====================================================
  • Wait ** MD: (3/28/19) Show Source page# column on the Officer Detail page for lookup reference/verification.


  • Wait - ** MD: (6/24/2019) Support the Users.Allow SwitchBankerState & Allow SwitchBankerCounty user options to Lock State/County search values (for example could have a PCHS login restricted to Pipestone County, MN searches). Also see IP Address login restriction below.
  • Wait - ** MD: (6/24/2019) ALSO Support the Users.UserPublicIPAddress1 & 2 (new fields), so (if not blank) ONLY allow login from these IP Address(es). (MD-Check code in windows modules). ** NOTE: Use the LocalIPAddress field/value (Equals PUBLIC IP Address) that is already getting set in SYXLog table.